Refactor/osgi rdy #4
Conversation
* prepare next development version * remove deprecated class * new snapshot version: test of new model and parser * more testing * add hashcode and equals functions * easier validation, proper logging * check for empty factors, add xml validator, fix: factor values were not properly created * add unit tests and schema resource * unstable update * renamed and added update functionality * formatting * add tests * update methods, slight restructuring * new constructor * add test * set deprecated * updating factor levels will now remove identifiers from old factor levels * add setter for value field * add test * add functionality to return all factos and properties for a single sample * add functionality to keep technology types without attached sample ids
Release/1.6.0
Codecov Report
@@ Coverage Diff @@
## development #4 +/- ##
=============================================
Coverage ? 0.00%
=============================================
Files ? 34
Lines ? 1075
Branches ? 237
=============================================
Hits ? 0
Misses ? 1075
Partials ? 0 Continue to review full report at Codecov.
|
| <groupId>life.qbic</groupId> | ||
| <artifactId>parent-pom</artifactId> | ||
| <version>2.4.0-SNAPSHOT</version> | ||
| <version>3.0.0</version> |
There was a problem hiding this comment.
do we want to keep the parent pom? I thought we remove it for osgi projects 🤔
There was a problem hiding this comment.
Good Catch! However I'd rather keep it in the current state for this PR and remove the Parent Pom in a seperate PR since this PR is pretty big already.
There was a problem hiding this comment.
ok, I am fine with that. Good idea to make this in a separate PR. Do you want to write an issue or so, just that we won't forget?
There was a problem hiding this comment.
I think it is really important therefore I want to make sure this really will be tackled at some point
|
The license was redrafted(deleted and added seperately) by SF and pushed directly to the master branch. |
5 participants
PR Goal
This PR enables the deployment of the
xml-manager-libas an OSGI Bundle and in a non OSGI context by introducing two distinct profiles in thepom.xml.Additionally it includes the
jaxb-coredependency which was removed in JDK 11.Additional Note
This PR adds the missing commits that were added directly to master to development to enable uniform development in the future.